New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#38059 Fix issue with product in cart's removed after… #38069

Closed

BeggiNN wants to merge 5 commits into magento:2.4-develop from BeggiNN:fix-for-issue-38059

Contributor

BeggiNN commented Oct 13, 2023 •

edited by engcom-Echo

Loading

Fix issue with product in cart's removed after reorder multiple times

Related Pull Requests

https://github.com/magento-gl/magento2b2b/pull/102

Description (*)

Product in cart's removed after reorder multiple times if reorder this order until the quantity of the above product reaches the Maximum Qty Allowed in Shopping Cart number

Fixed Issues (if relevant)

Fixes Product in cart's removed after reorder multiple times #38059

Manual testing scenarios (*)

Navigate to Admin -> Catalog -> Product -> Choose a product -> Advanced Inventory -> set Maximum Qty Allowed in Shopping Cart to a small number -> Save product.
Navigate to Shop page -> Login -> Order history page -> Reorder the order which contains the above product
Reorder this order until the quantity of the above product reaches the Maximum Qty Allowed in Shopping Cart number

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)


          magento#38059 Fix issue with product in cart's removed after reorder …

d72ecc9

…multiple times

m2-assistant bot commented Oct 13, 2023

Hi @BeggiNN. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-community-project bot added the Priority: P2 label

m2-github-services added Partner: Perspective Team partners-contribution labels

m2-community-project bot added the Progress: pending review label

Contributor Author

BeggiNN commented Oct 13, 2023

@magento run all tests

magento-automated-testing bot commented Oct 13, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Contributor Author

BeggiNN commented Oct 13, 2023

@magento run all tests

magento-automated-testing bot commented Oct 13, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Contributor Author

BeggiNN commented Oct 13, 2023

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

magento-automated-testing bot commented Oct 13, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

sinhaparul added the Project: Community Picked label

Contributor Author

BeggiNN commented Oct 16, 2023

@magento run Functional Tests CE

magento-automated-testing bot commented Oct 16, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel self-requested a review

October 17, 2023 08:21


          Merge branch '2.4-develop' into fix-for-issue-38059

ac476f6

m2-community-project bot added Progress: review and removed Progress: pending review labels

Contributor

engcom-Hotel commented Oct 17, 2023

@magento run all tests

magento-automated-testing bot commented Oct 17, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Contributor

engcom-Hotel commented Oct 19, 2023

@magento run Functional Tests B2B, Functional Tests EE

magento-automated-testing bot commented Oct 19, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel requested changes

View reviewed changes

Contributor

engcom-Hotel left a comment

Hello @BeggiNN,

Thanks for the contribution!

Failed tests seem flaky to me. But in accordance with DOD, please cover these changes with some automated tests.

Thanks

m2-community-project bot assigned engcom-Hotel

m2-community-project bot removed the Progress: needs update label

Contributor

engcom-Bravo commented May 14, 2024 •

edited

Loading

As per the PO these scenarios #38069 (review) will consider as a Feature Request.

As Per the PO Confirmation We are proceeding with this PR.

m2-community-project bot added Progress: ready for testing and removed Progress: on hold labels


          Merge branch '2.4-develop' into fix-for-issue-38059

0ed44a8

Contributor

engcom-Bravo commented May 14, 2024

@magento run all tests

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels

Contributor

engcom-Bravo commented May 14, 2024

@magento give me test instance

magento-deployment-service bot commented May 14, 2024

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service bot commented May 14, 2024

Hi @engcom-Bravo, here is your Magento Instance: https://11a7a71c55e06a2cc065efca74a1cf94.instances-prod.magento-community.engineering
Admin access: https://11a7a71c55e06a2cc065efca74a1cf94.instances-prod.magento-community.engineering/admin_88c1
Login: b39ea940
Password: 78335d8e7984

engcom-Bravo requested changes

View reviewed changes

Contributor

engcom-Bravo left a comment

Thanks for your Contribution.

The issue has been confirmed here #38059 (comment) now the issue is not reproducible.Kindly refer the attached video.

Screen.Recording.2024-05-14.at.15.57.50.mov

But we have observed a new issue that while reordering when the product exceeds maximum quantity it is giving an error but the product is added to the cart more than maximum quantity and there is no proceed to checkout option.

Screenshot 2024-05-14 at 15 42 50

Screenshot 2024-05-14 at 15 43 11

We have verified this issue with the PR changes it is not fixing the issue.Could you please check the behaviour and let us know if we are missing anything.

Thanks.

m2-community-project bot assigned engcom-Bravo

m2-community-project bot added Progress: needs update and removed Progress: testing in progress labels

m2-community-project bot added Progress: testing in progress and removed Progress: needs update labels

Contributor

engcom-Bravo commented May 21, 2024

We are not able to reproduce the issue.

Can you please confirm the issue still exist on 2.4-develop?

please refer to this #38069 (review)

Lets us know if you are still facing the issue on 2.4-develop with detailed steps.

Moving it to on hold

Thanks.

m2-community-project bot added Progress: on hold and removed Progress: testing in progress labels

Contributor

engcom-Bravo commented Jun 3, 2024

Thank you for your contribution!

As mentioned here, please have a look and let us know if we are missing anything.

Till then closing this PR. Please feel free to reopen it as you want to update further.

Thank you!

engcom-Bravo closed this

m2-community-project bot removed the Progress: on hold label

engcom-Bravo mentioned this pull request

Product in cart's removed after reorder multiple times #38059

Closed

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Perspective Team partners-contribution Priority: P2 Project: Community Picked